Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a little gift from the FSH mascot #194

Merged
merged 1 commit into from
Jan 14, 2025
Merged

add a little gift from the FSH mascot #194

merged 1 commit into from
Jan 14, 2025

Conversation

mint-thompson
Copy link
Collaborator

Description:
I wanted to send a little gift to FSH online users before my work on FSH projects officially ends. Now you can say ahoy to the little fish that lives in the corner of the top bar.

Testing Instructions:
When running FSH Online, try setting your canonical URL to ahoy to fsh. The fish in the top bar will say ahoy, and you should see a nice little message in the console.

Related Issue:
N/A

Copy link
Collaborator

@jafeltra jafeltra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magnificent 💯

Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing this very important feature.

@cmoesel cmoesel merged commit a38ddfe into master Jan 14, 2025
4 checks passed
@cmoesel cmoesel deleted the gift-from-shorty branch January 14, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants